refactor: inline push column

Unleash · Sep 23, 2024 · c17cb8f · c17cb8f
1 parent 70aab3a
commit c17cb8f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/src/lib/features/project/project-read-model.ts b/src/lib/features/project/project-read-model.ts
@@ -122,10 +122,9 @@ export class ProjectReadModel implements IProjectReadModel {
                     'MAX(events.created_at) AS last_updated',
             ),
             'project_settings.project_mode',
+            'projects.archived_at',
         ] as (string | Raw<any>)[];
 
-        selectColumns.push(`${TABLE}.archived_at`);
-
         let groupByColumns = ['projects.id', 'project_settings.project_mode'];
 
         if (userId) {
@@ -193,10 +192,9 @@ export class ProjectReadModel implements IProjectReadModel {
                     'count(features.name) FILTER (WHERE features.archived_at is null and features.potentially_stale IS TRUE) AS potentially_stale_feature_count',
             ),
             'project_stats.avg_time_to_prod_current_window',
+            'projects.archived_at',
         ] as (string | Raw<any>)[];
 
-        selectColumns.push(`${TABLE}.archived_at`);
-
         const groupByColumns = [
             'projects.id',
             'project_stats.avg_time_to_prod_current_window',

diff --git a/src/lib/features/project/project-store.ts b/src/lib/features/project/project-store.ts
@@ -152,10 +152,9 @@ class ProjectStore implements IProjectStore {
             'project_settings.default_stickiness',
             'project_settings.project_mode',
             'project_stats.avg_time_to_prod_current_window',
+            'projects.archived_at',
         ] as (string | Raw<any>)[];
 
-        selectColumns.push(`${TABLE}.archived_at`);
-
         let groupByColumns = [
             'projects.id',
             'project_settings.default_stickiness',
@@ -241,8 +240,7 @@ class ProjectStore implements IProjectStore {
     }
 
     async get(id: string): Promise<IProject> {
-        let extraColumns: string[] = [];
-        extraColumns = ['archived_at'];
+        const extraColumns: string[] = ['archived_at'];
 
         return this.db
             .first([...COLUMNS, ...SETTINGS_COLUMNS, ...extraColumns])