refactor: encapsulate playground limit in service (#7700)

Unleash · Jul 30, 2024 · c828d01 · c828d01
1 parent 50167d4
commit c828d01
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/src/lib/features/playground/playground-service.ts b/src/lib/features/playground/playground-service.ts
@@ -101,12 +101,18 @@ export class PlaygroundService {
         projects: typeof ALL | string[],
         environments: string[],
         context: SdkContextSchema,
-        limit: number,
         userId: number,
     ): Promise<{
         result: AdvancedPlaygroundFeatureEvaluationResult[];
         invalidContextProperties: string[];
     }> {
+        // used for runtime control, do not remove
+        const { payload } = this.flagResolver.getVariant('advancedPlayground');
+        const limit =
+            payload?.value && Number.isInteger(Number.parseInt(payload?.value))
+                ? Number.parseInt(payload?.value)
+                : 15000;
+
         const segments = await this.segmentReadModel.getActive();
 
         let filteredProjects: typeof projects = projects;

diff --git a/src/lib/features/playground/playground.ts b/src/lib/features/playground/playground.ts
@@ -118,19 +118,12 @@ export default class PlaygroundController extends Controller {
         res: Response<AdvancedPlaygroundResponseSchema>,
     ): Promise<void> {
         const { user } = req;
-        // used for runtime control, do not remove
-        const { payload } = this.flagResolver.getVariant('advancedPlayground');
-        const limit =
-            payload?.value && Number.isInteger(Number.parseInt(payload?.value))
-                ? Number.parseInt(payload?.value)
-                : 15000;
 
         const { result, invalidContextProperties } =
             await this.playgroundService.evaluateAdvancedQuery(
                 req.body.projects || '*',
                 req.body.environments,
                 req.body.context,
-                limit,
                 extractUserIdFromUser(user),
             );