Skip to content

Commit

Permalink
chore: remove flagResolver option (#6001)
Browse files Browse the repository at this point in the history
## About the changes
This option is not referenced in the code

I believe its original intent was to be able to override flagResolver,
but it's currently not being used:

https://github.com/Unleash/unleash/blob/a46f54f48afffdaf06126fa2998e61280dee03a3/src/lib/create-config.ts#L490-L491

Instead, we're using `experimental`, `flags`, and `externalResolver`


https://github.com/Unleash/unleash/blob/a46f54f48afffdaf06126fa2998e61280dee03a3/src/lib/create-config.ts#L64-L73


https://github.com/Unleash/unleash/blob/f63581c03a3bd2d520f26c900876f88246fe88d2/src/lib/util/flag-resolver.ts#L12-L20
  • Loading branch information
gastonfournier authored Jan 23, 2024
1 parent f63581c commit db93ab5
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/lib/types/option.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ export interface IUnleashOptions {
enterpriseVersion?: string;
inlineSegmentConstraints?: boolean;
clientFeatureCaching?: Partial<IClientCachingOption>;
flagResolver?: IFlagResolver;
accessControlMaxAge?: number;
prometheusApi?: string;
publicFolder?: string;
Expand Down

0 comments on commit db93ab5

Please sign in to comment.