fix: trim name and description before validation (#8275)

This fixes a bug where you can input just whitespace for
name/description. It also means that you can no longer have both "my
role" and "my role    " as separate roles.

API fix will follow.

frontend/src/component/admin/roles/RoleForm/RoleForm.tsx

@@ -28,10 +28,10 @@ const StyledInputFullWidth = styled(Input)({
 interface IRoleFormProps {
     type?: PredefinedRoleType;
     name: string;
-    setName: React.Dispatch<React.SetStateAction<string>>;
+    setName: (name: string) => void;
     validateName: (name: string) => boolean;
     description: string;
-    setDescription: React.Dispatch<React.SetStateAction<string>>;
+    setDescription: (description: string) => void;
     validateDescription: (description: string) => boolean;
     checkedPermissions: ICheckedPermissions;
     setCheckedPermissions: React.Dispatch<

frontend/src/component/admin/roles/RoleForm/useRoleForm.test.ts

@@ -0,0 +1,50 @@
+import { renderHook } from '@testing-library/react';
+import { useRoleForm } from './useRoleForm';
+import { act } from 'react-test-renderer';
+import { test } from 'vitest';
+
+describe('trim names and description', () => {
+    test('name is trimmed before being set', () => {
+        const { result } = renderHook(() => useRoleForm());
+
+        act(() => {
+            result.current.setName('  my role    ');
+        });
+
+        expect(result.current.name).toBe('my role');
+    });
+
+    test('description is trimmed before being set', () => {
+        const { result } = renderHook(() => useRoleForm());
+
+        act(() => {
+            result.current.setDescription('  my description    ');
+        });
+
+        expect(result.current.description).toBe('my description');
+    });
+
+    test('name that is just whitespace triggers an error', () => {
+        const { result } = renderHook(() => useRoleForm());
+
+        act(() => {
+            result.current.validateName('    ');
+        });
+
+        expect(result.current.errors).toMatchObject({
+            name: 'Name is required.',
+        });
+    });
+
+    test('description that is just whitespace triggers an error', () => {
+        const { result } = renderHook(() => useRoleForm());
+
+        act(() => {
+            result.current.validateDescription('    ');
+        });
+
+        expect(result.current.errors).toMatchObject({
+            description: 'Description is required.',
+        });
+    });
+});

frontend/src/component/admin/roles/RoleForm/useRoleForm.ts

@@ -27,7 +27,10 @@ export const useRoleForm = (
     const { roles, projectRoles } = useRoles();
 
     const [name, setName] = useState(initialName);
+    const setTrimmedName = (newName: string) => setName(newName.trim());
     const [description, setDescription] = useState(initialDescription);
+    const setTrimmedDescription = (newDescription: string) =>
+        setDescription(newDescription.trim());
     const [checkedPermissions, setCheckedPermissions] =
         useState<ICheckedPermissions>({});
     const [errors, setErrors] = useState<IRoleFormErrors>(DEFAULT_ERRORS);
@@ -78,12 +81,13 @@ export const useRoleForm = (
     };
 
     const validateName = (name: string) => {
-        if (!isNotEmpty(name)) {
+        const trimmedName = name.trim();
+        if (!isNotEmpty(trimmedName)) {
             setError(ErrorField.NAME, 'Name is required.');
             return false;
         }
 
-        if (!isNameUnique(name)) {
+        if (!isNameUnique(trimmedName)) {
             setError(ErrorField.NAME, 'Name must be unique.');
             return false;
         }
@@ -93,7 +97,8 @@ export const useRoleForm = (
     };
 
     const validateDescription = (description: string) => {
-        if (!isNotEmpty(description)) {
+        const trimmedDescription = description.trim();
+        if (!isNotEmpty(trimmedDescription)) {
             setError(ErrorField.DESCRIPTION, 'Description is required.');
             return false;
         }
@@ -139,10 +144,10 @@ export const useRoleForm = (
 
     return {
         name,
-        setName,
+        setName: setTrimmedName,
         validateName,
         description,
-        setDescription,
+        setDescription: setTrimmedDescription,
         validateDescription,
         checkedPermissions,
         setCheckedPermissions,