fix: now feature table does not dissapear (#8554)

Feature table does not dissapear when onboarding and filter settings hides all features
Unleash · Oct 28, 2024 · eaab9db · eaab9db
1 parent 622998c
commit eaab9db
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/...c/component/project/Project/PaginatedProjectFeatureToggles/ProjectFeatureToggles.test.tsx b/...c/component/project/Project/PaginatedProjectFeatureToggles/ProjectFeatureToggles.test.tsx
@@ -82,8 +82,7 @@ test('selects project features', async () => {
     expect(screen.queryByTestId(BATCH_SELECTED_COUNT)).not.toBeInTheDocument();
 });
 
-// TODO: stopped working after react v18 upgrade
-test.skip('filters by tag', async () => {
+test('filters by tag', async () => {
     setupApi();
     render(
         <Routes>
@@ -134,8 +133,7 @@ test('filters by flag type', async () => {
     await screen.findByText('Operational');
 });
 
-// TODO: stopped working after react v18 upgrade
-test.skip('filters by flag author', async () => {
+test('filters by flag author', async () => {
     setupApi();
     render(
         <Routes>

diff --git a/...nd/src/component/project/Project/PaginatedProjectFeatureToggles/ProjectFeatureToggles.tsx b/...nd/src/component/project/Project/PaginatedProjectFeatureToggles/ProjectFeatureToggles.tsx
@@ -134,8 +134,8 @@ export const ProjectFeatureToggles = ({
         onboardingUIEnabled &&
         project.onboardingStatus.status !== 'onboarded' &&
         onboardingFlow === 'visible';
-    const showFeaturesTable =
-        (total !== undefined && total > 0) || notOnboarding;
+    const noFeaturesExistInProject = project.featureTypeCounts?.length === 0;
+    const showFeaturesTable = !noFeaturesExistInProject || notOnboarding;
 
     const trackOnboardingFinish = (sdkName: string) => {
         if (!isOnboarding) {