fix: make search selects explicit (#7445)

Now we are not returning * columns, but all tables that we join later, will need to select columns one by one.
Unleash · Jun 25, 2024 · ed7f917 · ed7f917
1 parent 388fe2d
commit ed7f917
Showing 1 changed file with 18 additions and 6 deletions.
diff --git a/src/lib/features/feature-search/feature-search-store.ts b/src/lib/features/feature-search/feature-search-store.ts
@@ -299,7 +299,13 @@ class FeatureSearchStore implements IFeatureSearchStore {
                         'client_metrics_env.environment',
                     ]);
             })
-            .select('*')
+            .select([
+                'ranked_features.*',
+                'total_features.total',
+                'final_ranks.final_rank',
+                'metrics.yes',
+                'metrics.no',
+            ])
             .from('ranked_features')
             .innerJoin(
                 'final_ranks',
@@ -310,11 +316,17 @@ class FeatureSearchStore implements IFeatureSearchStore {
             .whereBetween('final_rank', [offset + 1, offset + limit])
             .orderBy('final_rank');
         if (featureLifecycleEnabled) {
-            finalQuery.leftJoin(
-                'lifecycle',
-                'ranked_features.feature_name',
-                'lifecycle.stage_feature',
-            );
+            finalQuery
+                .select(
+                    'lifecycle.latest_stage',
+                    'lifecycle.stage_status',
+                    'lifecycle.entered_stage_at',
+                )
+                .leftJoin(
+                    'lifecycle',
+                    'ranked_features.feature_name',
+                    'lifecycle.stage_feature',
+                );
         }
         this.queryExtraData(finalQuery);
         const rows = await finalQuery;