feat: filter by tags #5163
Merged
feat: filter by tags #5163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
FredrikOseberg
approved these changes
Oct 26, 2023
Comment on lines
78
to
80
| ?.map((t) => t.split(':')) | ||
| .filter((t) => t.length === 2); | ||
| const features = await this.featureSearchService.search({ |
There was a problem hiding this comment.
Suggested change
| ?.map((t) => t.split(':')) | |
| .filter((t) => t.length === 2); | |
| const features = await this.featureSearchService.search({ | |
| ?.map((tag) => tag.split(':')) | |
| .filter((tag) => tag.length === 2); | |
| const features = await this.featureSearchService.search({ |
| const userId = req.user.id; | ||
| const normalizedTag = tag |
There was a problem hiding this comment.
Is this actually tags since it's an array?
There was a problem hiding this comment.
we have to decide whether our query params use singular or plural form. Currently I stick to singular because in the url it looks like this: tag[]=simple:tag1&tag[]=simple:tag2
There was a problem hiding this comment.
If we decide to make plural then I'll adjust all query params in one go. For now I prefer consistency
| @@ -542,6 +543,13 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore { | |||
| .whereILike('features.name', `%${queryString}%`) | |||
| .orWhereIn('features.name', tagQuery); | |||
| } | |||
| if (tag && tag.length > 0) { | |||
There was a problem hiding this comment.
Again, plural here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Filter by tags
Important files
Discussion points