Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: banners #5173

Merged
merged 3 commits into from
Oct 27, 2023
Merged

docs: banners #5173

merged 3 commits into from
Oct 27, 2023

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Oct 27, 2023

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview Oct 27, 2023 11:47am
1 Ignored Deployment
Name Status Preview Updated (UTC)
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Oct 27, 2023 11:47am

@@ -155,6 +155,7 @@ module.exports = {
'how-to/how-to-add-feature-flag-naming-patterns',
'how-to/how-to-capture-impression-data',
'how-to/how-to-create-feature-toggles',
'how-to/how-to-create-and-display-banners',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if this belongs here 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially, yes

@nunogois nunogois changed the title Docs banners docs: banners Oct 27, 2023
Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed through it and it looks good!

@dgorton dgorton merged commit d3bd591 into main Oct 27, 2023
7 checks passed
@dgorton dgorton deleted the docs-banners branch October 27, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants