refactor: switch to upstream express-openapi #5259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is ignored for now, but will be made available in the next version of the package.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
… without type Luckily, even without it, `null` is a valid value.
thomasheartman
commented
Nov 3, 2023
src/lib/openapi/spec/patch-schema.ts
Outdated
There was a problem hiding this comment.
The updated deps were complaining that you can't use a nullable attribute without a type. But if you have no type, null is already a valid value, so that's all good!
thomasheartman
commented
Nov 3, 2023
| }; | ||
|
|
||
| // Sometimes, the error object contains a dataPath, even if it's not | ||
| type ActualErrorObject = ErrorObject & { dataPath?: string }; |
There was a problem hiding this comment.
I think it's possible that the data that previously resided in dataPath is now available in instancePath, so I'll try to make a follow-up PR where I fix that.
thomasheartman
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the express-openapi implementation from our internal fork to the upstream version. We have upstreamed our changes and a new version has been released, so this should be the last step before we can retire our fork.
Because some of the dependencies have been updated since our internal fork, we also need to update some of our error handling to reflect this.