Feat: scheduled change request dialogs #5267
Conversation
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
| <StyledAlert icon={false}> | ||
| There is a scheduled time to apply these changes set for{' '} | ||
| <strong> | ||
| <br /> |
There was a problem hiding this comment.
Why are we using the br element? If we need to space this out, we should do that with styling, not html, I think.
There was a problem hiding this comment.
The reason I user br is that the designs look to me to require it be in a new line. What would be a better way to do it?
There was a problem hiding this comment.
Yeah, this sounds like a styling thing to me. The way I've always learnt is that visual-only things should be done with CSS, not HTML. So for instance, if you need the strong element to be on its own line, you could use css to give it display: block instead. It's not a super important thing, but more of a ... best practices thing. At least as far as I'm aware.
|
re your concerns: are the tests not (good) enough? |
Creates the Apply and Reject scheduled change request dialogs
Closes # 1-1584
Closes # 1-1586
UI e2e tests will be in a follow up PR