chore: expose type and more fixes #5268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
gastonfournier
commented
Nov 3, 2023
| metrics: ClientMetricsSchema, | ||
| ip: string, | ||
| ): Promise<void> { | ||
| ProxyService.assertExpectedTokenType(token); | ||
|
|
||
| const environment = | ||
| this.services.clientMetricsServiceV2.resolveMetricsEnvironment( | ||
| token, | ||
| token as ApiUser, |
There was a problem hiding this comment.
Not so easy to change cause we're testing user instanceof ApiUser inside resolveMetricsEnvironment. We can't just use isAPI because we also have users who are APIs (service accounts IIRC)
chriswk
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose new interface while also getting rid of unneeded compiler ignores
None of the changes should add new security risks, despite this report:
Not sure what that means, maybe a removed ignore...