Chore: remove "dataPath" from data OpenAPI data errors. #5272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `dataPath` was present (but not typed) in previous versions of the error library that we use. But with the recent major upgrade, it's been removed and the `instancePath` property has finally come into use. This PR removes all the handling for the previous property and replaces it with `instancePath`. Because the `dataPath` used full stops and the `instancePath` uses slashes, we need to change a little bit of the handling too.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
thomasheartman
commented
Nov 6, 2023
|
|
||
| const youSent = JSON.stringify(input); | ||
| const description = `The \`.${propertyName}\` property ${errorMessage}. You sent ${youSent}.`; | ||
| const description = `The \`${propertyName}\` property ${errorMessage}. You sent ${youSent}.`; |
There was a problem hiding this comment.
No other property descriptors start with a full stop, and because the new format uses slashes, I'll remove it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dataPathwas present (but not in the type) in previous versions of theerror library that we use. But with the recent major upgrade, it's
been removed and the
instancePathproperty has finally come into use.This PR removes all the handling for the previous property and
replaces it with
instancePath. Because thedataPathused fullstops and the
instancePathuses slashes, we need to change a littlebit of the handling too.