feat: schedule changes dialog #5285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andreas-unleash <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
thomasheartman
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Looks good! I some small text suggestions, but nothing blocking. We should probably go over all the text before we finish off the project (I'll make a task for it), so it's not super important to do now, but if you like the suggestions we might as well use them.
...eRequest/ChangeRequestOverview/ChangeRequestScheduledDialogs/ScheduleChangeRequestDialog.tsx
Outdated
Show resolved
Hide resolved
...eRequest/ChangeRequestOverview/ChangeRequestScheduledDialogs/ScheduleChangeRequestDialog.tsx
Outdated
Show resolved
Hide resolved
...eRequest/ChangeRequestOverview/ChangeRequestScheduledDialogs/ScheduleChangeRequestDialog.tsx
Outdated
Show resolved
Hide resolved
...eRequest/ChangeRequestOverview/ChangeRequestScheduledDialogs/ScheduleChangeRequestDialog.tsx
Outdated
Show resolved
Hide resolved
…ngeRequestScheduledDialogs/ScheduleChangeRequestDialog.tsx Co-authored-by: Thomas Heartman <[email protected]>
…ngeRequestScheduledDialogs/ScheduleChangeRequestDialog.tsx Co-authored-by: Thomas Heartman <[email protected]>
…ngeRequestScheduledDialogs/ScheduleChangeRequestDialog.tsx Co-authored-by: Thomas Heartman <[email protected]>
…ngeRequestScheduledDialogs/ScheduleChangeRequestDialog.tsx Co-authored-by: Thomas Heartman <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #
1-1585
1-1582
Manually tested e2e -> Approve -> Schedule -> Reschedule -> Apply/Reject: ui tests verifying it in next pr