feat: connect search and filter with server api #5297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sjaanus
commented
Nov 8, 2023
| columns?: string[]; | ||
| } = { id: 'createdAt' }; | ||
|
|
||
| export const PaginatedProjectFeatureToggles = ({ |
There was a problem hiding this comment.
This is same as ProjectFeatureToggles, but pulling out a lot of dependencies. Not using frontend search/filtering anymore, but features coming in from backend
sjaanus
commented
Nov 8, 2023
| @@ -45,7 +45,7 @@ const handleFilter = ( | |||
|
|
|||
| if (isStatusFilter(key, values)) { | |||
| return addStatusFilters(key, values, filterParams); | |||
| } else if (key === 'tag') { | |||
| } else if (key === 'tags') { | |||
There was a problem hiding this comment.
Fixing key, because from FE we are putting in tags not tag
sjaanus
commented
Nov 8, 2023
| @@ -45,7 +52,7 @@ export const useFeatureSearch = ( | |||
| const returnData = data || fallbackData; | |||
| return { | |||
| ...returnData, | |||
| loading: !error && !data, | |||
| loading: false, | |||
There was a problem hiding this comment.
This is temporary until we find a better solution for loading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.