chore: detect if a segment is being used in an active CR #5298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out it was using the fake read model, which doesn't help much here.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
thomasheartman
changed the title
|
Closing in favor of #5301. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a way to tell if a specific segment is being used in any active change requests. It's the first step towards preventing segments that are being used in change requests from being deleted.
It does that by checking the db for any unclosed CRs and using those CR ids to look for "addStrategy" and "updateStrategy" events in the cr events table.
Discussion points
I've implemented this as part of the change request access read model because it was the closest we had, but it feels kinda dirty. I think I'd like to refactor it out into its own module ("change-request-segment-usage-read-model" or something?), but I suggest doing that in a separate PR (to keep the changes in this PR manageable). I'd much appreciate some thoughts on that.
Upcoming PRs
This only puts in a way to detect it, but doesn't add that to anything. That'll be in an upcoming iteration.