Feat: scheduled change request badges #5300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Co-authored-by: Thomas Heartman <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
… feat/scheduled_cr_ui_tests
Signed-off-by: andreas-unleash <[email protected]>
# Conflicts: # frontend/src/component/changeRequest/ChangeRequestOverview/ChangeRequestOverview.test.tsx
Signed-off-by: andreas-unleash <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
andreas-unleash
changed the title
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
thomasheartman
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
I wonder if it's better to export two separate components for this? They could probably be from the same file and use the same internal method, but it'd give two separate methods for clarity. What do you think?
There was a problem hiding this comment.
sure makes sense
There was a problem hiding this comment.
This looks good, but boy, is it a lot of lines 😄 Was this copied from somewhere? And I feel like the file name is misleading. Doesn't feel like there's anything related to draggable items being tested here. Maybe change it or add something to indicate that we're testing change request badges?
There was a problem hiding this comment.
Yes from live Network calls :). Refactored for readability
...OverviewEnvironment/EnvironmentAccordionBody/StrategyDraggableItem/StrategyDraggableItem.tsx
Outdated
Show resolved
Hide resolved
...nvironmentAccordionBody/StrategyDraggableItem/StrategyItem/useStrategyChangesFromRequest.tsx
Outdated
Show resolved
Hide resolved
…tureOverviewEnvironments/FeatureOverviewEnvironment/EnvironmentAccordionBody/StrategyDraggableItem/StrategyDraggableItem.tsx Co-authored-by: Thomas Heartman <[email protected]>
…tureOverviewEnvironments/FeatureOverviewEnvironment/EnvironmentAccordionBody/StrategyDraggableItem/StrategyItem/useStrategyChangesFromRequest.tsx Co-authored-by: Thomas Heartman <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
…at/scheduled_cr_badge
Signed-off-by: andreas-unleash <[email protected]>
thomasheartman
approved these changes
Nov 9, 2023
...end/src/component/changeRequest/ModifiedInChangeRequestStatusBadge/ChangesScheduledBadge.tsx
Outdated
Show resolved
Hide resolved
...iewEnvironment/EnvironmentAccordionBody/StrategyDraggableItem/StrategyDraggableItem.test.tsx
Outdated
Show resolved
Hide resolved
...OverviewEnvironment/EnvironmentAccordionBody/StrategyDraggableItem/StrategyDraggableItem.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: andreas-unleash <[email protected]>
…atusBadge/ChangesScheduledBadge.tsx Co-authored-by: Thomas Heartman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new badge to strategies that have changes in an a scheduled change request
Closes # 1-1620
