Feat: remove last seen refactor flag #5423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Signed-off-by: andreas-unleash <[email protected]>
…lag' into feat/remove-last-seen-refactor-flag # Conflicts: # src/lib/features/feature-toggle/tests/feature-toggle-last-seen-at.e2e.test.ts # src/lib/features/playground/advanced-playground.test.ts # src/server-dev.ts
andreas-unleash
requested review from
thomasheartman and
dgorton
as code owners
Signed-off-by: andreas-unleash <[email protected]>
andreas-unleash
changed the title
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
FredrikOseberg
commented
Nov 30, 2023
| @@ -77,14 +77,13 @@ test('returns three archived toggles', async () => { | |||
| }); | |||
|
|
|||
| test('returns three archived toggles with archivedAt', async () => { | |||
| expect.assertions(3); | |||
There was a problem hiding this comment.
Why did this have to change?
There was a problem hiding this comment.
no archive, just archivedAt
There was a problem hiding this comment.
It seems strange to me that the changes in this PR should affect this? Or am I missing something?
There was a problem hiding this comment.
I know, that's why I said I had to fix unrelated tests around this, the scheduled-service and maintenance mode. Strange
| @@ -0,0 +1,122 @@ | |||
| import { LogProvider } from '../logger'; | |||
There was a problem hiding this comment.
Why is this file new?
There was a problem hiding this comment.
Not sure, I rebased the branch from main
andreas-unleash
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the box