chore: move enterprise check further left, prevent OSS from seeing CR usage #5431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thomasheartman
commented
Nov 27, 2023
There was a problem hiding this comment.
This is just a refactor to remove duplication.
If we change the payload to always include changeRequestStrategies, we can remove the flag check entirely. For now, this flag check retains the previous shape of the object.
There was a problem hiding this comment.
Only look up change request strategies if it's relevant. Meaning: only if the flag is enabled (for now) and if we're on an enterprise instance.
thomasheartman
changed the title
thomasheartman
deleted the
chore/restrict-cr-strategies-to-enterprise
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks that the unleash instance is an enterprise instance before fetching change request data. This is to prevent Change Request usage from preventing OSS users from deleting segments (when they don't have access to change requests).
This PR also does a little bit of refactoring (which we can remove if you want)