chore: list users and groups under each role in projectaccessadded event #5581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ivarconr
approved these changes
Dec 11, 2023
| users: [{ username: testUsername }], | ||
| roleId: 1, | ||
| groupIds: [1, 2], | ||
| users: [{ id: 1, username: testUsername }], |
There was a problem hiding this comment.
should we drop the username? Feels like a user id should be enough?
There was a problem hiding this comment.
This is only in the test, it's actually a PII test that just happens to use that particular event.
There was a problem hiding this comment.
I can take a look at removing this particular test/making it a more appropriate test.
There was a problem hiding this comment.
I've added a comment to the test that explains the use case and that it's specific to testing PII and not directly relevant of the event itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Replaces #5509
Changes the project access added event to list all users and groups added to each role instead of in root event.
Discussion points