chore:system user and events created by userid migrations #5612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
chriswk
requested changes
Dec 12, 2023
chriswk
reviewed
Dec 12, 2023
chriswk
reviewed
Dec 12, 2023
Co-authored-by: Christopher Kolstad <[email protected]>
Co-authored-by: Christopher Kolstad <[email protected]>
chriswk
approved these changes
Dec 12, 2023
nunogois
reviewed
Dec 13, 2023
nunogois
reviewed
Dec 13, 2023
|
Test added, I've updated the username of the system user @nunogois |
nunogois
reviewed
Dec 22, 2023
| INSERT INTO users | ||
| (id, name, username, email, created_by_user_id, is_system) | ||
| VALUES | ||
| (-1337, 'Unleash System', 'unleash_system_user', '[email protected]', -1337, true); |
There was a problem hiding this comment.
Even though I like -1337, I'm wondering if we should just use -1 instead.
nunogois
reviewed
Dec 22, 2023
| expect(userResults[1].is_system).toEqual(false); | ||
| expect(userResults[1].id).toEqual(1); | ||
| expect(userResults[1].username).toEqual('testperson'); | ||
| }); |
daveleek
deleted the
chore/system-user-events-created-by-userid-migrations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Migrations for:
includes
is_system: falsein the activeUsers where filterTested by running:
select * into users_pre_check from users where id > -1; delete from users where id > -1;before starting unleash, then inspecting users table after unleash has started and verifying that an 'admin' user has been created.