fix: make username nullable in user-schema #5656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed I was getting warnings logged in my local instance when
visiting the users page (`/admin/users`)
```json
{
"schema": "#/components/schemas/publicSignupTokensSchema",
"errors": [
{
"instancePath": "/tokens/0/users/0/username",
"schemaPath": "#/components/schemas/userSchema/properties/username/type",
"keyword": "type",
"params": {
"type": "string"
},
"message": "must be string"
}
]
}
```
It was complaining because one of my users doesn't have a username, so
the value returned from the API was:
```json
{
"users": [
{
"id": 2,
"name": "2mas",
"username": null
}
]
}
```
This adjustment fixes that oversight by allowing `null` values for the username.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kwasniew
approved these changes
Dec 15, 2023
ivarconr
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed I was getting warnings logged in my local instance when
visiting the users page (
/admin/users){ "schema": "#/components/schemas/publicSignupTokensSchema", "errors": [ { "instancePath": "/tokens/0/users/0/username", "schemaPath": "#/components/schemas/userSchema/properties/username/type", "keyword": "type", "params": { "type": "string" }, "message": "must be string" } ] }It was complaining because one of my users doesn't have a username, so
the value returned from the API was:
{ "users": [ { "id": 2, "name": "2mas", "username": null } ] }This adjustment fixes that oversight by allowing
nullvalues for the username.