Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use semver compatible version #5678

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

gastonfournier
Copy link
Contributor

About the changes

Replicate the change made to respect semver

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 3:45pm
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 3:45pm

Comment on lines +50 to +53
// clean removes +anything modifier from the version
expect(version).toMatch(
new RegExp(`^${semver.clean(version) ?? 'invalid semver'}`),
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasheartman just making sure you're aware of this little change, now the version in openapi will be 5.7.0 while the version of the server will be 5.7.0+main.<build>.<sha> which is an unexpected outcome but I think it's a good one

Previously, this was showing -main in the version:
image

Copy link
Contributor

@daveleek daveleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks for the walk through and explanation

@gastonfournier gastonfournier merged commit 061bd7e into main Dec 19, 2023
13 checks passed
@gastonfournier gastonfournier deleted the chore/respect-semver branch December 19, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants