feat: add created by in search results #7285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
kwasniew
commented
Jun 5, 2024
| @@ -133,6 +133,11 @@ class FeatureSearchStore implements IFeatureSearchStore { | |||
| 'ft.tag_value as tag_value', | |||
| 'ft.tag_type as tag_type', | |||
| 'segments.name as segment_name', | |||
| 'users.id as user_id', | |||
There was a problem hiding this comment.
I'm very careful here to avoid duplicate names
kwasniew
commented
Jun 5, 2024
| @@ -407,6 +417,15 @@ class FeatureSearchStore implements IFeatureSearchStore { | |||
| dependencyType: row.dependency, | |||
| environments: [], | |||
| segments: row.segment_name ? [row.segment_name] : [], | |||
| createdBy: { | |||
| id: Number(row.user_id), | |||
| name: | |||
There was a problem hiding this comment.
hiding fallback from the UI
kwasniew
commented
Jun 5, 2024
| type: 'object', | ||
| description: 'User who created the feature flag', | ||
| additionalProperties: false, | ||
| required: ['id', 'name', 'imageUrl'], |
There was a problem hiding this comment.
decided to go for nulls instead of null + undefined. All fields will always be provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Adding created by section with id, name and avatar img for the search results. Search table will have a user avatar (next PR)
Important files
Discussion points