feat: display created by user in search #7292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
|
Have we considered how it looks for old feature flags created before we supported created_by_user_id? Will it then just say system user? |
Whats the argument to not flag this? |
thomasheartman
approved these changes
Jun 6, 2024
| @@ -28,7 +28,7 @@ export interface FeatureSearchResponseSchema { | |||
| */ | |||
| createdAt: string | null; | |||
| /** User who created the feature flag */ | |||
| createdBy?: FeatureSearchResponseSchemaCreatedBy; | |||
| createdBy: FeatureSearchResponseSchemaCreatedBy; | |||
There was a problem hiding this comment.
will this always have a created by even in old flags? We did do some sort of patching of pre-existing flags, didn't we?
| row.user_name || | ||
| row.user_username || | ||
| row.user_email || | ||
| 'unknown'; |
There was a problem hiding this comment.
Is the unknown case where we don't know who created the flag initially? Like Ivar asked, what do we show then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Displaying columns with created by user:
Currently we show avatar and user name + id on hover.
Next PR:
Important files
Discussion points
Should we put it behind a dedicated flag? It's a new table column that's visible by default on large screens.