feat: exclude archived features in max reporting #7559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
kwasniew
commented
Jul 9, 2024
| this.db.raw( | ||
| 'feature_strategies, jsonb_array_elements(constraints) AS constraint_value', |
There was a problem hiding this comment.
this had to be rewritten to cross join after adding join to the feature table so that the syntax is correct
thomasheartman
approved these changes
Jul 9, 2024
| 'features.name', | ||
| 'feature_strategies.feature_name', | ||
| ) | ||
| .where('features.archived_at', null); |
There was a problem hiding this comment.
I wonder: if a feature is archived and then revived, is archived_at set to null again? I know we've run into issues with this before, but I think that archived_at might have been the solution?
There was a problem hiding this comment.
I tested this manually and reviving brings the feature back to the reported metrics
There was a problem hiding this comment.
Added one test to show archived feature exclusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
When reporting max values in prometheus metrics we want to exclude strategies that belong to archived features. It means we need to join with the features table in the queries.
Important files
Discussion points