fix: don't delete projects screen from history #7787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in the navigation when you create a project. It used to be that we'd replace the current entry in the browser history when we took you to a separate form for it. However, now that we instead use a dialog, we don't want to replace the history. Before: if you created a project and navigated back, you'd be taken to the page you were at BEFORE you went to the projects page, whether that was in Unleash or otherwise. Now you'll be taken back to the projects page.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
sjaanus
approved these changes
Aug 7, 2024
thomasheartman
added a commit
that referenced
this pull request
Aug 7, 2024
Fixes a bug in the navigation when you create a project. It used to be that we'd replace the current entry in the browser history when we took you to a separate form for it. However, now that we instead use a dialog, we don't want to replace the history. Before: if you created a project and navigated back, you'd be taken to the page you were at BEFORE you went to the projects page, whether that was in Unleash or otherwise. Now you'll be taken back to the projects page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the navigation when you create a project. It used to be
that we'd replace the current entry in the browser history when we
took you to a separate form for it. However, now that we instead
use a dialog, we don't want to replace the history.
Before: if you created a project and navigated back, you'd be taken to
the page you were at BEFORE you went to the projects page, whether
that was in Unleash or otherwise.
Now you'll be taken back to the projects page.