Projects archive UI #7842
Merged
Projects archive UI #7842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
kwasniew
reviewed
Aug 13, 2024
| @@ -55,9 +55,15 @@ const BreadcrumbNav = () => { | |||
| .map(decodeURI); | |||
|
|
|||
| if (location.pathname === '/insights') { | |||
| // Because of sticky header in Insights | |||
There was a problem hiding this comment.
how is it related to archive?
There was a problem hiding this comment.
Comment was missing. I'll remember to add this kind of fixes in separate PRs in the future
kwasniew
reviewed
Aug 13, 2024
| @@ -23,12 +24,25 @@ const StyledCardLink = styled(Link)(({ theme }) => ({ | |||
| pointer: 'cursor', | |||
| })); | |||
|
|
|||
| export const ProjectGroup: React.FC<{ | |||
| type ProjectGroupProps<T extends { id: string } = IProjectCard> = { | |||
There was a problem hiding this comment.
is the extends because we're spreading remaining props?
There was a problem hiding this comment.
It's because we are using projects[id] for both mapped ProjectCardComponent and links.
kwasniew
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Closes issue/1-2666
Discussion points