feat: dialogs for project revive and delete #7863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Tymek
force-pushed
the
feat/archive-project-list-dialogs
branch
from
eda518f to
38c7b71
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
kwasniew
reviewed
Aug 15, 2024
| @@ -77,6 +77,16 @@ export default class ProjectController extends Controller { | |||
| summary: 'Get a list of all projects.', | |||
| description: | |||
| 'This endpoint returns an list of all the projects in the Unleash instance.', | |||
| parameters: [ | |||
There was a problem hiding this comment.
I guess we'll need to repeat it in the enterprise since this method is duplicated
There was a problem hiding this comment.
in Enterprise there is this comment:
https://github.com/ivarconr/unleash-enterprise/blob/fa284169f6f4a282d9a26bfed18aa2a5ba8346c3/src/project/project-controller.ts#L123
// this operation is also described in OSS, so that operation will take precedence in the output. In other words, anything you put here is ignored.
kwasniew
reviewed
Aug 15, 2024
| @@ -5,7 +5,7 @@ import { HtmlTooltip } from 'component/common/HtmlTooltip/HtmlTooltip'; | |||
| import { Badge } from 'component/common/Badge/Badge'; | |||
|
|
|||
| interface IProjectModeBadgeProps { | |||
| mode: 'private' | 'protected' | 'public' | string; | |||
| mode?: 'private' | 'protected' | 'public' | string; | |||
There was a problem hiding this comment.
why do we relax the constraint?
There was a problem hiding this comment.
Component was already written in a way that if any other string is provided, it will be ignored
kwasniew
reviewed
Aug 15, 2024
frontend/src/component/project/ProjectList/ReviveProjectDialog/ReviveProjectDialog.tsx
Show resolved
Hide resolved
kwasniew
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Dialogs needed to comfirm revive/delete actions