feat: allow editing root role/description on SCIM group #7874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
sighphyre
changed the title
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
sighphyre
commented
Aug 14, 2024
| @@ -30,6 +30,10 @@ import type { IUser } from '../types/user'; | |||
| import type EventService from '../features/events/event-service'; | |||
| import { SSO_SYNC_USER } from '../db/group-store'; | |||
|
|
|||
| const setsAreEqual = (firstSet, secondSet) => | |||
There was a problem hiding this comment.
This is ugly and bloats the call site where it's actually relevant but only really useful in one place so I've pulled it out into a non exported function
sighphyre
commented
Aug 14, 2024
| @@ -106,6 +106,7 @@ export const CreateGroup = () => { | |||
| handleSubmit={handleSubmit} | |||
| handleCancel={handleCancel} | |||
| mode={CREATE} | |||
| isScimGroup={false} | |||
There was a problem hiding this comment.
This is the create flow - can't be a SCIM group if SCIM didn't make it!
daveleek
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relaxes validation on modifying SCIM groups.
From a UI perspective, users are now allowed to access the edit screen for SCIM groups (previously you couldn't click the relevant UI elements and if you navigated manually you'd just get the save button disabled). Now instead updating the name is disabled and modifying the SSO mappings is hidden. The usual places that previously blocked you from changing users are still disabled.
On the backend, validation has been relaxed to allow some editing of groups, so long as you're not changing the name or modifying the users (effectively the only two properties SCIM cares about).