feat: support private projects for event search #7884
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
| expect(result).toBe('IS:project1'); | ||
| }); | ||
|
|
||
| it('should throw an error if no projects match and not throw an error', () => { |
There was a problem hiding this comment.
Huh? What's this test supposed to say? Something like this?
| it('should throw an error if no projects match and not throw an error', () => { | |
| it('should throw an error if no projects match', () => { |
| mode: 'all', | ||
| }; | ||
|
|
||
| const projectParam = 'IS:project1,IS:project3'; |
There was a problem hiding this comment.
Project param the query parameter in the URL, right? If you have multiple projects, it's formatted as an IS_ANY_OF:, not as a concatenated list of IS (e.g. https://sandbox.getunleash.io/enterprise/history?query=&limit=25&offset=0&project=IS_ANY_OF%3A61ab6557353d%2Candreas_test).
We should probably use the same kinda query string, yeah?
(Side note: how does the API handle multiples of the same query param? E.g. "project=IS_ANY_OF:a,b&project=IS:c"?)
There was a problem hiding this comment.
Fixed. Side note, not sure actually, but it is not supposed to be used that way, and only doable via API.
Adds private projects support for event search. Unit test should cover the usecases.