fix: exclude archived features in segments count #7886
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
| ) | ||
| .select([ | ||
| ...this.prefixColumns(), | ||
| this.db.raw( |
There was a problem hiding this comment.
The COUNT functions are now wrapped with CASE statements. These CASE statements ensure that only non-archived features (where features.archived_at is NULL) are counted. If a feature is archived, the CASE returns NULL, which does not affect the count, effectively making it 0
| @@ -145,6 +144,11 @@ export default class SegmentStore implements ISegmentStore { | |||
| `${T.featureStrategies}.id`, | |||
| `${T.featureStrategySegment}.feature_strategy_id`, | |||
| ) | |||
| .leftJoin( | |||
There was a problem hiding this comment.
added a new join to get feature archived info
There was a problem hiding this comment.
I also tried the where clause just before groupBy instead of rewriting counts but it didn't work.
| @@ -48,7 +48,7 @@ describe('usage counting', () => { | |||
| await db.rawDatabase.table('change_requests').delete(); | |||
| }); | |||
|
|
|||
| test('segment usage in active CRs is counted iff we ask for it', async () => { | |||
| test('segment usage in active CRs is counted if we ask for it', async () => { | |||
There was a problem hiding this comment.
This wasn't actually a typo, but shorthand for "if and only if", but maybe I should've written it out? 😅
About the changes
Exclude archived feature flags from the segment usage count calculations
Making sure this list count
matches this strategy values
Important files
Discussion points