Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gitar] Cleaning up stale flag: killInsightsUI with value false #7892

Closed
wants to merge 2 commits into from
Closed

[Gitar] Cleaning up stale flag: killInsightsUI with value false #7892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
515dd7c
[Gitar] Updating TypeScript files
Aug 15, 2024
935d694
[Gitar] Updating TSX files
Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions frontend/src/component/layout/MainLayout/NavigationSidebar/NavigationList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import AccordionDetails from '@mui/material/AccordionDetails';
import AccordionSummary from '@mui/material/AccordionSummary';
import ExpandMoreIcon from '@mui/icons-material/ExpandMore';
import FlagIcon from '@mui/icons-material/OutlinedFlag';
import { useUiFlag } from 'hooks/useUiFlag';
import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
import useProjectOverview from 'hooks/api/getters/useProjectOverview/useProjectOverview';
import { ProjectIcon } from 'component/common/ProjectIcon/ProjectIcon';
Expand Down Expand Up @@ -156,7 +155,6 @@ export const PrimaryNavigationList: FC<{
activeItem?: string;
}> = ({ mode, onClick, activeItem }) => {
const DynamicListItem = mode === 'mini' ? MiniListItem : FullListItem;
const killInsightsDashboard = useUiFlag('killInsightsUI');
const { isOss } = useUiConfig();

return (
Expand Down Expand Up @@ -186,7 +184,7 @@ export const PrimaryNavigationList: FC<{
<PlaygroundIcon />
</DynamicListItem>
<ConditionallyRender
condition={!killInsightsDashboard && !isOss()}
condition={!isOss()}
show={
<DynamicListItem
href='/insights'
Expand Down
21 changes: 1 addition & 20 deletions frontend/src/component/menu/Header/OldHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ import { Notifications } from 'component/common/Notifications/Notifications';
import { useAdminRoutes } from 'component/admin/useAdminRoutes';
import InviteLinkButton from './InviteLink/InviteLinkButton/InviteLinkButton';
import { useUiFlag } from 'hooks/useUiFlag';
import { Badge } from '../../common/Badge/Badge';

const HeaderComponent = styled(AppBar)(({ theme }) => ({
backgroundColor: theme.palette.background.paper,
Expand Down Expand Up @@ -117,23 +116,6 @@ const styledIconProps = (theme: Theme) => ({

const StyledLink = styled(Link)(({ theme }) => focusable(theme));

const StyledText = styled('div')(({ theme }) => ({
display: 'flex',
alignItems: 'center',
gap: theme.spacing(1),
}));

const StyledLinkWithBetaBadge = ({
title,
to,
}: { title: string; to: string }) => (
<StyledLink to={to} sx={{ margin: 0 }}>
<StyledText>
<span>{title}</span> <Badge color='success'>Beta</Badge>
</StyledText>
</StyledLink>
);

const StyledIconButton = styled(IconButton)<{
component?: 'a' | 'button';
href?: string;
Expand Down Expand Up @@ -164,7 +146,6 @@ const OldHeader: VFC = () => {
const onAdminClose = () => setAdminRef(null);
const onConfigureClose = () => setConfigRef(null);
const celebatoryUnleash = useUiFlag('celebrateUnleash');
const killInsightsDashboard = useUiFlag('killInsightsUI');

const routes = getRoutes();
const adminRoutes = useAdminRoutes();
Expand Down Expand Up @@ -242,7 +223,7 @@ const OldHeader: VFC = () => {
<StyledLink to={'/search'}>Search</StyledLink>
<StyledLink to='/playground'>Playground</StyledLink>
<ConditionallyRender
condition={!killInsightsDashboard && !isOss()}
condition={!isOss()}
show={
<StyledLink to='/insights'>Insights</StyledLink>
}
Expand Down
1 change: 0 additions & 1 deletion frontend/src/interfaces/uiConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ export type UiFlags = {
featureSearchFeedback?: Variant;
enableLicense?: boolean;
adminTokenKillSwitch?: boolean;
killInsightsUI?: boolean;
feedbackComments?: Variant;
displayUpgradeEdgeBanner?: boolean;
showInactiveUsers?: boolean;
Expand Down
1 change: 0 additions & 1 deletion src/lib/__snapshots__/create-config.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ exports[`should create default config 1`] = `
"improveCreateFlagFlow": false,
"insightsV2": false,
"integrationEvents": false,
"killInsightsUI": false,
"killScheduledChangeRequestCache": false,
"maintenanceMode": false,
"manyStrategiesPagination": false,
Expand Down
5 changes: 0 additions & 5 deletions src/lib/types/experimental.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ export type IFlagKey =
| 'edgeBulkMetrics'
| 'extendedUsageMetrics'
| 'adminTokenKillSwitch'
| 'killInsightsUI'
| 'feedbackComments'
| 'showInactiveUsers'
| 'killScheduledChangeRequestCache'
Expand Down Expand Up @@ -185,10 +184,6 @@ const flags: IFlags = {
process.env.UNLEASH_EXPERIMENTAL_ADMIN_TOKEN_KILL_SWITCH,
false,
),
killInsightsUI: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_KILL_INSIGHTS_UI,
false,
),
outdatedSdksBanner: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_OUTDATED_SDKS_BANNER,
false,
Expand Down
1 change: 0 additions & 1 deletion src/server-dev.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ process.nextTick(async () => {
stripHeadersOnAPI: true,
celebrateUnleash: true,
featureSearchFeedbackPosting: true,
killInsightsUI: false,
userAccessUIEnabled: true,
outdatedSdksBanner: true,
disableShowContextFieldSelectionValues: false,
Expand Down
Loading