fix: avoid awkward overlaps of group cards with lots of members, long project names, and small cards #7915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
…ar the lower edge of the card
thomasheartman
changed the title
kwasniew
reviewed
Aug 19, 2024
| @@ -85,6 +87,10 @@ const InfoBadgeDescription = styled('span')(({ theme }) => ({ | |||
| fontSize: theme.fontSizes.smallBody, | |||
| })); | |||
|
|
|||
| const ProjectNameBadge = styled(Badge)({ | |||
| wordwrap: 'anywhere', | |||
There was a problem hiding this comment.
I haven't seen this anywhere else in our codebase. How would it work with 'break-word'?
There was a problem hiding this comment.
looks like styled has some issues with the word-wrap property (wordWrap would render correctly as word-wrap, but linter told me the property was invalid; wordwrap was accepted by the linter, but rendered as wordwrap so it didn't work), so I'll go with word-break: break-word instead.
kwasniew
approved these changes
Aug 19, 2024
thomasheartman
deleted the
fix/1-2635-group-card-avatars-cover-up-project-names-when-names-are
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the styling of the group cards to better handle edge cases where you have a lot of assigned projects, long project names, lots of members, etc.
In particular, it does the following things:
Note: there is one more thing I'd like to address in a follow up: as shown in the top row of the after image, there's some extra wrapping of the first "This group has no users", even though it has the room to grow. I'll keep looking into this and make a follow-up.
Before:
After: