[Gitar] Cleaning up stale flag: integrationEvents with value true #7940
Conversation
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
| properties: { | ||
| integrationEvents: { | ||
| type: 'array', | ||
| description: 'A list of integration events.', | ||
| items: { | ||
| $ref: integrationEventSchema.$id, | ||
| }, | ||
| }, | ||
| }, | ||
| properties: {}, |
There was a problem hiding this comment.
Hmmm this doesn't seem right if we're keeping the feature and just removing the feature flag
There was a problem hiding this comment.
I'm guessing this is because the did a grep for integrationEvents without considering whether something is a string or a "name".
There was a problem hiding this comment.
We do not do "grep" to transform the code. There are scenarios where it is OK to delete this entry, e.g.,
flags: {
integrationEvents: true,
},
We need to discuss and agree on when it is safe to delete and when it is not. @sjaanus
src/lib/routes/admin-api/addon.ts
Outdated
| const normalizedLimit = | ||
| Number(limit) > 0 && Number(limit) <= 100 ? Number(limit) : 50; | ||
| const normalizedOffset = Number(offset) > 0 ? Number(offset) : 0; | ||
|
|
||
| const integrationEvents = | ||
| await this.integrationEventsService.getPaginatedEvents( | ||
| id, | ||
| normalizedLimit, | ||
| normalizedOffset, | ||
| ); | ||
|
|
||
| this.openApiService.respondWithValidation( | ||
| 200, | ||
| res, | ||
| integrationEventsSchema.$id, | ||
| { | ||
| integrationEvents: serializeDates(integrationEvents), | ||
| }, | ||
| {}, |
There was a problem hiding this comment.
This looks a little weird, we're keeping the feature
There was a problem hiding this comment.
Same thing as the other one, I guess. It just looks for integrationEvents, thinks "oh, I can delete that" and then also cleans up where it's used. We should see if we can fix that somehow.
…at were deleted in error
This automated PR was generated by Gitar. View docs.