Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misc fixes for project archive #7948

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Aug 21, 2024

About the changes

Addressing the following breakathon findings:

  • archive project 404 page wording
  • prevent revive project when limit exceeded
  • API command for archive (method and URL changed)
  • navigate to revived project after revive

Archive card text overflow is a separate PR as it also applies to the main project list.

Important files

Discussion points

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 8:17am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Aug 21, 2024 8:17am

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@@ -6,7 +6,7 @@ export const ProjectArchived: FC<{ name: string }> = ({ name }) => {
<p>
The project <strong>{name}</strong> has been archived. You can find
it on the{' '}
<Link to={`/projects-archive`}>projects archive page</Link>.
<Link to={`/projects-archive`}>archive page for projects</Link>.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're making it more difficult to confuse it with single project archive page

@kwasniew kwasniew merged commit ee1d8ee into main Aug 21, 2024
12 of 14 checks passed
@kwasniew kwasniew deleted the project-archive-misc-fixes branch August 21, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants