Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove create feature component #7959

Merged
merged 3 commits into from
Aug 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions frontend/src/component/common/BreadcrumbNav/BreadcrumbNav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ const BreadcrumbNav = () => {
item !== 'copy' &&
item !== 'features' &&
item !== 'features2' &&
// TODO: this can be removed after new create flag flow goes live
item !== 'create-toggle' &&
item !== 'settings' &&
item !== 'profile' &&
item !== 'insights',
Expand Down

This file was deleted.

235 changes: 0 additions & 235 deletions frontend/src/component/feature/CreateFeature/CreateFeature.tsx

This file was deleted.

15 changes: 3 additions & 12 deletions frontend/src/component/feature/EditFeature/EditFeature.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import FormTemplate from 'component/common/FormTemplate/FormTemplate';
import { useNavigate } from 'react-router-dom';
import FeatureForm from '../FeatureForm/FeatureForm';
import EditFeatureForm from '../FeatureForm/EditFeatureForm';
import useFeatureForm from '../hooks/useFeatureForm';
import * as jsonpatch from 'fast-json-patch';
import { UpdateButton } from 'component/common/UpdateButton/UpdateButton';
Expand All @@ -26,15 +26,12 @@ const EditFeature = () => {
type,
setType,
name,
setName,
project,
setProject,
description,
setDescription,
impressionData,
setImpressionData,
clearErrors,
errors,
} = useFeatureForm(
feature?.name,
feature?.type,
Expand Down Expand Up @@ -88,25 +85,19 @@ const EditFeature = () => {
documentationLinkLabel='Feature flag types documentation'
formatApiCode={formatApiCode}
>
<FeatureForm
<EditFeatureForm
type={type}
name={name}
project={project}
description={description}
setType={setType}
setName={setName}
setProject={setProject}
setDescription={setDescription}
errors={errors}
handleSubmit={handleSubmit}
handleCancel={handleCancel}
impressionData={impressionData}
setImpressionData={setImpressionData}
mode='Edit'
clearErrors={clearErrors}
>
<UpdateButton permission={UPDATE_FEATURE} projectId={project} />
</FeatureForm>
</EditFeatureForm>
</FormTemplate>
);
};
Expand Down
Loading
Loading