Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when backporting we don't want to push latest docker tag (#7961) #7966

Merged
merged 3 commits into from
Aug 22, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/docker_publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ on:
description: "Which version to release"
type: 'string'
required: true
is-latest-version:
description: Is this the latest version? If latest we'll update the version docker
required: true
type: boolean
default: true
workflow_dispatch:

jobs:
Expand Down Expand Up @@ -39,6 +44,7 @@ jobs:
with:
images: |
unleashorg/unleash-server
flavor: latest=${{ github.event.inputs.is-latest-version }}
tags: |
# only enabled for workflow dispatch except main (assume its a release):
type=semver,pattern={{ version }},enable=${{ github.event_name == 'workflow_dispatch' && github.ref != 'refs/heads/main' }},value=${{ inputs.version }}
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/publish-new-version.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ concurrency:

permissions:
contents: write
id-token: write
id-token: write

on:
workflow_dispatch:
Expand All @@ -18,8 +18,8 @@ on:
required: true
type: boolean
default: true
update-version-function:
description: Should we update the version function to use this version?
is-latest-version:
description: Is this the latest version? If latest we'll update the version function, docker and npm latest
required: true
type: boolean
default: true
Expand All @@ -30,7 +30,7 @@ jobs:

strategy:
matrix:
node-version: [20.x]
node-version: [ 20.x ]

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -118,7 +118,7 @@ jobs:
secrets: inherit
with:
version: ${{ github.event.inputs.version }}

publish-npm:
needs: build
uses: ./.github/workflows/release.yaml
Expand All @@ -134,7 +134,7 @@ jobs:

update-version-checker:
needs: publish-docker
if: ${{ github.event.inputs.update-version-function == 'true' }}
if: ${{ github.event.inputs.is-latest-version == 'true' }}
uses: ./.github/workflows/update_version_for_version_checker.yml
secrets: inherit
with:
Expand Down
Loading