Django tutorial + Nav update #7982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
sighphyre
requested changes
Aug 27, 2024
|
|
||
| Click the 'New feature flag' button to create a new feature flag. | ||
|
|
||
|  |
There was a problem hiding this comment.
If we're reusing the Ruby images then I think they should get moved to some kind of common folder. I think it''s too easy if you're in the Ruby space to assume that those images are only used by that tutorial and make changes affecting this one
There was a problem hiding this comment.
I agree, but we do this everywhere. I can make another PR to address that
There was a problem hiding this comment.
Sure, can't complain if it's an existing pattern
website/docs/feature-flag-tutorials/django/implementing-feature-flags-django.md
Outdated
Show resolved
Hide resolved
website/docs/feature-flag-tutorials/django/implementing-feature-flags-django.md
Show resolved
Hide resolved
website/docs/feature-flag-tutorials/django/implementing-feature-flags-django.md
Outdated
Show resolved
Hide resolved
website/docs/feature-flag-tutorials/django/implementing-feature-flags-django.md
Outdated
Show resolved
Hide resolved
website/docs/feature-flag-tutorials/django/implementing-feature-flags-django.md
Show resolved
Hide resolved
website/docs/feature-flag-tutorials/django/implementing-feature-flags-django.md
Outdated
Show resolved
Hide resolved
website/docs/feature-flag-tutorials/django/implementing-feature-flags-django.md
Outdated
Show resolved
Hide resolved
website/docs/feature-flag-tutorials/django/implementing-feature-flags-django.md
Show resolved
Hide resolved
website/docs/feature-flag-tutorials/django/implementing-feature-flags-django.md
Show resolved
Hide resolved
website/docs/feature-flag-tutorials/django/implementing-feature-flags-django.md
Outdated
Show resolved
Hide resolved
website/docs/feature-flag-tutorials/django/implementing-feature-flags-django.md
Outdated
Show resolved
Hide resolved
website/docs/feature-flag-tutorials/django/implementing-feature-flags-django.md
Outdated
Show resolved
Hide resolved
website/docs/feature-flag-tutorials/django/implementing-feature-flags-django.md
Outdated
Show resolved
Hide resolved
…e-flags-django.md Co-authored-by: Simon Hornby <[email protected]>
…e-flags-django.md Co-authored-by: Melinda Fekete <[email protected]>
…e-flags-django.md Co-authored-by: Melinda Fekete <[email protected]>
…e-flags-django.md Co-authored-by: Melinda Fekete <[email protected]>
…e-flags-django.md Co-authored-by: Melinda Fekete <[email protected]>
…e-flags-django.md Co-authored-by: Simon Hornby <[email protected]>
melindafekete
approved these changes
Sep 3, 2024
website/docs/feature-flag-tutorials/django/implementing-feature-flags-django.md
Outdated
Show resolved
Hide resolved
website/docs/feature-flag-tutorials/django/implementing-feature-flags-django.md
Outdated
Show resolved
Hide resolved
…e-flags-django.md Co-authored-by: Melinda Fekete <[email protected]>
…e-flags-django.md Co-authored-by: Melinda Fekete <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the nav so Django and Rails are both listed under their respective language.