feat: onboarding store #8027
Merged
feat: onboarding store #8027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
kwasniew
commented
Aug 30, 2024
| this.eventBus.on(STAGE_ENTERED, async (stage: NewStage) => { | ||
| if (!this.flagResolver.isEnabled('onboardingMetrics')) return; | ||
|
|
||
| if (stage.stage === 'initial') { |
There was a problem hiding this comment.
we do this translation since there's not 100% domain vocab match between lifecycle and onboarding. lifecycle cares about initial flag, while onboarding cares about the first flag created
kwasniew
commented
Aug 30, 2024
| } from './onboarding-store-type'; | ||
| import { millisecondsToSeconds } from 'date-fns'; | ||
|
|
||
| type DBInstanceType = { |
There was a problem hiding this comment.
sticking to dashed convention as in lifecycle events instead of camel casing
kwasniew
commented
Aug 30, 2024
| event: OnboardingEvent['type'], | ||
| ): DBInstanceType['event'] => { | ||
| if (event === 'flag-created') { | ||
| return 'first-flag'; |
There was a problem hiding this comment.
can be also first-flag-created.
Overall progression: 'initial' in lifecycle -> 'flag-created' in service -> 'first-flag-created' when we confirm it's the first one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Next PR:
Important files
Naming convention:
initialevent arrived from the lifecycle subdomain. It is translated toflag-createdin the onboarding subdomain. One we confirm it's the first flag created we store it asfirst-flagin the DB.Discussion points