feat: onboarding table to prometheus #8034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
sjaanus
commented
Sep 2, 2024
| @@ -31,13 +22,9 @@ afterAll(async () => { | |||
| } | |||
| }); | |||
|
|
|||
| beforeEach(async () => { | |||
| await userStore.deleteAll(); | |||
| jest.useRealTimers(); | |||
There was a problem hiding this comment.
We dont need to use fake timers anymore.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
sjaanus
commented
Sep 2, 2024
| return millisecondsToMinutes(diffInMilliseconds); | ||
| } | ||
| return null; | ||
| const instanceEventLookup = { |
There was a problem hiding this comment.
Need mapping for new column format
There was a problem hiding this comment.
maybe we can use the - notation for the metrics so that we can skip mapping?
There was a problem hiding this comment.
did we add camel case to be consistent with other metrics?
There was a problem hiding this comment.
I just dont want to mess with json object with - in the key.
kwasniew
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of lifecycle table, we take the metrics directly from onboarding tables.