Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: connect sdk step 1 #8042

Merged
merged 2 commits into from
Sep 2, 2024
Merged

feat: connect sdk step 1 #8042

merged 2 commits into from
Sep 2, 2024

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Sep 2, 2024

About the changes

Dialog to configure SDK key in one environment.
Screenshot 2024-09-02 at 14 40 23

Details:

  • added usage of a dialogue in the most convenient location but for now it's always disabled
  • passing project and environments from the outside (parent component passes only enabled envs which is probably what we want)
  • re-using single selection component that was created for the project and feature dialogs (env selection works out of the box)

Next PRs:

  • add stepper
  • add tests when the component is ready
  • connect buttons for token generation, add next step with generated token
  • connect next button

Important files

Discussion points

Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend 🛑 Canceled (Inspect) Sep 2, 2024 0:56am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 0:56am

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

</SectionDescription>
{environments.length > 0 ? (
<SingleSelectConfigButton
tooltip={{ header: '' }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to skip the header and only show description on hover

@@ -489,6 +490,13 @@ export const ProjectFeatureToggles = ({
{rowActionsDialogs}

{featureToggleModals}

<ConnectSDKDialog
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sample usage with open always set to false, next PR will do proper connection

Copy link
Contributor

@sjaanus sjaanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@kwasniew kwasniew merged commit 82f9783 into main Sep 2, 2024
9 of 11 checks passed
@kwasniew kwasniew deleted the onboarding-connect-sdk-step-1 branch September 2, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants