fix: force languages in cypress browser for tests #8049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
gastonfournier
changed the title
|
Ok, not trying to sound aggressive, but why are we even using millify here? Is it that important to get thousand separators? |
We're only using it in a few places and we're consciously adding it for things like: #7879 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix this we had to create a free trial account on cypress and enable the recording of the test. That way we found out the issue was with a locale:
Probably, this works well locally because our local machines do have a default locale, but probably we don't have one when running in CI, and millify library is causing the tests to fail specifically at this line:
unleash/frontend/src/component/common/AvatarGroup/AvatarGroup.tsx
Line 89 in 363911c
Unfortunately, upgrading millify didn't help, but downgrading to v5 (which doesn't support locales), solve the issue at the cost of not having the up-to-date library: #8048
I believe the issue is related to this locale
creported here: cypress-io/cypress#7890 (comment) because only after overriding the languages this worked