feat: Onboarding connect api token generation #8054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
kwasniew
commented
Sep 3, 2024
| @@ -185,49 +428,8 @@ export const ConnectSDKDialog = ({ | |||
| </NextStepSectionSpacedContainer> | |||
| </NextStepSection> | |||
| </APIKeyGeneration> | |||
| <ConceptsDefinitions> | |||
There was a problem hiding this comment.
extracted to separate component for readability
kwasniew
commented
Sep 3, 2024
| ); | ||
| }; | ||
|
|
||
| const ChooseEnvironment = ({ |
There was a problem hiding this comment.
extracted into component for readability
kwasniew
commented
Sep 3, 2024
| return null; | ||
| } | ||
|
|
||
| const ConceptsDefinitions = () => ( |
There was a problem hiding this comment.
extracted for readability
kwasniew
commented
Sep 3, 2024
| @@ -59,7 +67,7 @@ export const APIKeyGeneration = styled('div')(({ theme }) => ({ | |||
| backgroundColor: theme.palette.background.paper, | |||
| display: 'flex', | |||
| flexDirection: 'column', | |||
| flexBasis: '70%', | |||
| flex: 1, | |||
There was a problem hiding this comment.
take whole dialog in mobile view
sjaanus
reviewed
Sep 3, 2024
| fontSize: theme.fontSizes.smallBody, | ||
| })); | ||
|
|
||
| function splitToken( |
There was a problem hiding this comment.
Can this be const splitToken, and can we have test for it?
sjaanus
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
When Clicking generate token or token exists for a given env you get token anatomy
On mobile we move extra information and only show the token
Details:
Important files
Discussion points