Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sdk snippets in test connection phase #8082

Merged
merged 10 commits into from
Sep 4, 2024
Merged

feat: Sdk snippets in test connection phase #8082

merged 10 commits into from
Sep 4, 2024

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Sep 4, 2024

About the changes

Added sample snippets for all SDKs (install and initialize)
Screenshot 2024-09-04 at 15 21 12

Details:

  • separated shared types and shared component
  • separated snippets to a separate file (they will probably change at a different pace than the UI layout)
  • the actual layout change is about 100 LOC, the rest is code snippets

Next PRs:

  • add feature check based on first project flag
  • add in-between steps e.g. android requires some permission checking
  • add code snippet copy
  • consult with SDK owners the best example we can give (e.g. sync vs async)

Important files

Discussion points

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 1:34pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 1:34pm

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

| 'Swift'
| 'Android'
| 'Flutter';
export type SdkName = ServerSdkName | ClientSdkName;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added for extra type safety to avoid typos in other places

@kwasniew kwasniew merged commit ff31013 into main Sep 4, 2024
11 checks passed
@kwasniew kwasniew deleted the sdk-snippets branch September 4, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants