feat: add sdk example box #8092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sjaanus
commented
Sep 5, 2024
sjaanus
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
kwasniew
reviewed
Sep 5, 2024
...rc/component/project/Project/PaginatedProjectFeatureToggles/ProjectOnboarding/SdkExample.tsx
Outdated
Show resolved
Hide resolved
kwasniew
reviewed
Sep 5, 2024
| import { type SelectChangeEvent, styled, Typography } from '@mui/material'; | ||
| import { Link } from 'react-router-dom'; | ||
| import Select from '../../../../common/select'; | ||
| import { OFFICIAL_SDKS } from '../../../../integrations/IntegrationList/AvailableIntegrations/SDKs'; |
There was a problem hiding this comment.
I added the SDK list (at the type level, we can add value level list too) in the onboarding directory. The file is called sharedTypes.ts. We can use the integrations dir but I wanted to control which ones we display in the onboarding just in case the lists don't match between integrations and onboarding.
There was a problem hiding this comment.
We have value level lists in the SelectSdk.tsx so you can export it from there. Then we don't depend on the other module.
kwasniew
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.