feat: new onboarding welcome screen logic #8110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sjaanus
commented
Sep 6, 2024
sjaanus
commented
- We will not show grid until 2 flags exist
- Now new feature creation button will be always displayed on top with different style
- Moved some text around
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
kwasniew
reviewed
Sep 6, 2024
| ]} | ||
| onToggle={onToggleColumnVisibility} | ||
| <ConditionallyRender | ||
| condition={total !== undefined && total > 1} |
There was a problem hiding this comment.
Maybe extract variable refactoring?
There was a problem hiding this comment.
Also do we want to add ConditionallyRender to new code?
kwasniew
approved these changes
Sep 6, 2024
sjaanus
commented
Sep 6, 2024
| </PageContent> | ||
| } | ||
| /> | ||
| {'feature' in project.onboardingStatus ? ( |
There was a problem hiding this comment.
@kwasniew moved this out of feature toggle list, because if we hide the list, dialog can not open
sjaanus
commented
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.