Fix/default strategy permission cherry pick #8144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8114) Allow you to edit default strategies in the UI if you have the update_project or project_default_strategy_write permissions. These are the same permissions that we use in the API. Previously, we used the update_feature_strategy permission here, but that one is intended to be used for updating strategies belonging to actual flags. One of the trickier bits here is that we use the `StrategyVariants` component, which previously had baked in the permission required (update_feature_environment_variants). Because the permissions are different for the default strategy, I updated the component to make it configurable, but for the default to be the old permission (so that other uses aren't affected).
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
thomasheartman
approved these changes
Sep 16, 2024
…fault strategy (#8112) This appears to have been an oversight in the original implementation of this endpoint. This seems to be the primary point of this permission. Additionally, the docs mention that this permission should allow you to do just that. Note: I've not added any tests for this, because we don't typically add tests for it. If we have an example to follow, I'd be very happy to add it, though
FredrikOseberg
deleted the
fix/default-strategy-permission-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick #8113, #8114 and #8112