Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add eventTimeline feature flag #8159

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Sep 17, 2024

https://linear.app/unleash/issue/2-2658/create-eventtimeline-feature-flag

Adds a new eventTimeline feature flag for the new event timeline feature.

I think eventTimeline is an appropriate name given the feature description and the way it is evolving, but I'm open to suggestions. This also assumes that this feature will target OSS. Confirmed that this will be a premium feature.

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 7:52am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 7:52am

Copy link
Contributor

github-actions bot commented Sep 17, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

@daveleek daveleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need the snapshot update don't you? Apart from that LGTM!

Edit: Did we disable the snapshots?

@nunogois
Copy link
Member Author

You need the snapshot update don't you? Apart from that LGTM!

Edit: Did we disable the snapshots?

Had the same thought you did, so I went to check and apparently we omitted the flags from the snap in #8041

@nunogois nunogois merged commit 85b67ae into main Sep 18, 2024
12 checks passed
@nunogois nunogois deleted the chore-event-timeline-feature-flag branch September 18, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants