feat: Personal flags UI component #8221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
kwasniew
commented
Sep 23, 2024
| export const PersonalDashboard = () => { | ||
| const { user } = useAuthUser(); | ||
|
|
||
| const name = user?.name; | ||
|
|
||
| const { projects, activeProject, setActiveProject } = useProjects(); | ||
|
|
||
| const { personalDashboard } = usePersonalDashboard(); |
There was a problem hiding this comment.
I will extract this code into a custom hook once we find shared items between flags and projects
thomasheartman
approved these changes
Sep 24, 2024
Comment on lines
184
to
185
| personalDashboard?.flags.length && | ||
| personalDashboard?.flags.length > 0 |
There was a problem hiding this comment.
Is this meant to be more like this (though both will work)?
Suggested change
| personalDashboard?.flags.length && | |
| personalDashboard?.flags.length > 0 | |
| personalDashboard?.flags && | |
| personalDashboard?.flags.length > 0 |
We should also be able to simplify it:
Suggested change
| personalDashboard?.flags.length && | |
| personalDashboard?.flags.length > 0 | |
| personalDashboard?.flags.length > 0 |
though TS might require us to do
Suggested change
| personalDashboard?.flags.length && | |
| personalDashboard?.flags.length > 0 | |
| (personalDashboard?.flags.length ?? 0) > 0 |
at which point ... maybe?
There was a problem hiding this comment.
if(personalDashboard?.flags.length) will do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Details:
Important files
Discussion points