chore: event timeline header placement #8234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
nunogois
changed the title
nunogois
added a commit
that referenced
this pull request
Sep 26, 2024
I believe the changes in #8234, more specifically [this change](https://github.com/Unleash/unleash/pull/8234/files#diff-3a5e0763fe1effa9cd485763fecf0633ce8f0877c9d1971e6bd5c5abe7426364L64), have caused the main layout content to no longer stretch to its maximum relative width on larger screens. This adjustment seems to resolve this issue, ensuring proper behavior on larger screens without introducing any overflow issues on smaller screens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-2662/make-the-event-timeline-available-globally-through-a-new-header-button
unleash-event-timeline.mp4
(In the video, you’ll notice a slight delay before new events show up. This happens because the timeline automatically refreshes every 10 seconds)
Removes the event timeline from the event log and integrates it into a new header option.
I chose a middle-ground approach between options 1 and 2 from our Figma sketches. This solution provides the best of both worlds IMO: the timeline stands out as a global component, distinct from the current page context, while sliding in rather than overlapping the content. This way, users can view the timeline alongside the page content.